Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TFM External Interface URL #3989

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Update TFM External Interface URL #3989

merged 2 commits into from
Dec 4, 2024

Conversation

JeremyParish69
Copy link
Collaborator

@JeremyParish69 JeremyParish69 commented Dec 3, 2024 •
edited
Loading

What is the purpose of the change:

The old URL (with 'geo' in it), is geoblocked, and trying to connect a wallet just goes right to their '/blocked' page (at least for a few countries like UK and Canada, probably US, too). The app.tfm.com does not do this, and allows connecting to a wallet.

Brief Changelog

  • updates packages/bridge/src/ibc/index.ts:: literally ONLY the tfm URL (1 line of code)
    • also updates a test based on that. (1 line of code)

Testing and Verifying

This change has not been tested locally, because I can't run FE locally.
But I've validated on the generated Vercel build here in this PR (success!).

@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 9:59pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
osmosis-frontend-datadog ⬜️ Ignored (Inspect) Dec 3, 2024 9:59pm
osmosis-frontend-dev ⬜️ Ignored (Inspect) Dec 3, 2024 9:59pm
osmosis-frontend-edgenet ⬜️ Ignored (Inspect) Dec 3, 2024 9:59pm
osmosis-testnet ⬜️ Ignored (Inspect) Dec 3, 2024 9:59pm

@JeremyParish69 JeremyParish69 self-assigned this Dec 3, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2024

Walkthrough

The changes in this pull request involve modifications to the IbcBridgeProvider test suite and the implementation of the getExternalUrl method. The URL used in the method has been updated from "https://geo.tfm.com/" to "https://app.tfm.com/". Additionally, enhancements were made to the tests for the getQuote method to ensure proper error handling for invalid parameters and adjustments to the mock implementation of estimateGasFee. A new public method, getIbcSourcePublic, was added to facilitate testing of asset transfer functionalities.

Changes

File Path Change Summary
packages/bridge/src/ibc/__tests__/ibc-bridge-provider.spec.ts Updated tests for getExternalUrl method to reflect new URL; enhanced getQuote tests for error handling; added public method getIbcSourcePublic for testing asset transfers.
packages/bridge/src/ibc/index.ts Modified getExternalUrl method to change the URL from "https://geo.tfm.com/" to "https://app.tfm.com/".

Possibly related PRs

  • (Deposit/Withdrawal) Fix atom stargaze withdrawal #3946: This PR modifies the getQuote method in the SkipBridgeProvider class, enhancing error handling related to unsupported quotes, which is relevant to the changes made in the main PR regarding the getQuote method and the BridgeQuoteError.
  • (Deposit/Withdraw) Fix Penumbra Issue #3966: This PR introduces the PenumbraBridgeProvider, which includes a getExternalUrl method that throws an error for unsupported URLs, similar to the changes in the main PR where the getExternalUrl method's URL was updated.

Suggested reviewers

  • JoseRFelix

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/bridge/src/ibc/__tests__/ibc-bridge-provider.spec.ts

Oops! Something went wrong! :(

ESLint: 8.50.0

ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct.

The config "prettier" was referenced from the config file in "/packages/bridge/.eslintrc.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 23ba7b0 and d1af086.

📒 Files selected for processing (2)
  • packages/bridge/src/ibc/__tests__/ibc-bridge-provider.spec.ts (1 hunks)
  • packages/bridge/src/ibc/index.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/bridge/src/ibc/index.ts
🔇 Additional comments (3)
packages/bridge/src/ibc/__tests__/ibc-bridge-provider.spec.ts (3)

334-334: LGTM: URL update matches PR objective.

The URL change from geo.tfm.com to app.tfm.com aligns with the PR objective to resolve geoblocking issues in the UK and Canada.

Line range hint 1-350: LGTM: Comprehensive test coverage.

The test suite thoroughly covers all critical aspects:

  • Error handling for invalid chains
  • Quote generation and gas fee calculations
  • IBC source validation
  • Asset support verification
  • URL generation with the updated domain

334-334: Verify all occurrences of the old URL have been updated.

Let's ensure there are no remaining instances of the old URL in the codebase.

✅ Verification successful

All URL references have been properly updated to app.tfm.com

The verification shows that:

  • No instances of the old domain geo.tfm.com were found in the codebase
  • The new domain app.tfm.com is consistently used in both:
    • Main implementation (packages/bridge/src/ibc/index.ts)
    • Test file (packages/bridge/src/ibc/__tests__/ibc-bridge-provider.spec.ts)
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for any remaining instances of the old URL
# Expected: No occurrences of geo.tfm.com should be found

echo "Searching for old URL pattern..."
rg -i "geo\.tfm\.com"

echo "Searching for new URL pattern to verify update locations..."
rg -i "app\.tfm\.com"

Length of output: 491

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JeremyParish69 JeremyParish69 merged commit f4f9be6 into stage Dec 4, 2024
34 of 35 checks passed
@JeremyParish69 JeremyParish69 deleted the JP69/upd-tfm-url branch December 4, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonator jonator jonator approved these changes

Assignees

@JeremyParish69 JeremyParish69

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeremyParish69 @jonator